netdev - Re: [PATCH net V2 4/4] net: vertexcom: mse102x: Fix RX error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd31ce70-4157-42fe-b398-f1ed6e188506@lunn.ch>
Date: Wed, 30 Apr 2025 15:47:00 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Stefan Wahren <wahrenst@....net>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH net V2 4/4] net: vertexcom: mse102x: Fix RX error handling

On Wed, Apr 30, 2025 at 03:30:43PM +0200, Stefan Wahren wrote:
> In case the CMD_RTS got corrupted by interferences, the MSE102x
> doesn't allow a retransmission of the command. Instead the Ethernet
> frame must be shifted out of the SPI FIFO. Since the actual length is
> unknown, assume the maximum possible value.

I assume the SPI transfer won't get the beginning of the next frames
to make up the shortfall of bytes when the frame is short?

> Fixes: 2f207cbf0dd4 ("net: vertexcom: Add MSE102x SPI support")
> Signed-off-by: Stefan Wahren <wahrenst@....net>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew