netdev - Re: [PATCH net] virtio-net: free xsk_buffs on error in virtnet_xsk_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEvRE-hNRu5CvqdzxnhjQXo8FOqSWUUbg6towh+uUOHVeg@mail.gmail.com>
Date: Wed, 30 Apr 2025 11:40:46 +0800
From: Jason Wang <jasowang@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, mst@...hat.com, 
	xuanzhuo@...ux.alibaba.com, eperezma@...hat.com, hawk@...nel.org, 
	john.fastabend@...il.com, virtualization@...ts.linux.dev, 
	minhquangbui99@...il.com
Subject: Re: [PATCH net] virtio-net: free xsk_buffs on error in virtnet_xsk_pool_enable()

On Wed, Apr 30, 2025 at 12:43 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> The selftests added to our CI by Bui Quang Minh recently reveals
> that there is a mem leak on the error path of virtnet_xsk_pool_enable():
>
> unreferenced object 0xffff88800a68a000 (size 2048):
>   comm "xdp_helper", pid 318, jiffies 4294692778
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace (crc 0):
>     __kvmalloc_node_noprof+0x402/0x570
>     virtnet_xsk_pool_enable+0x293/0x6a0 (drivers/net/virtio_net.c:5882)
>     xp_assign_dev+0x369/0x670 (net/xdp/xsk_buff_pool.c:226)
>     xsk_bind+0x6a5/0x1ae0
>     __sys_bind+0x15e/0x230
>     __x64_sys_bind+0x72/0xb0
>     do_syscall_64+0xc1/0x1d0
>     entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> Fixes: e9f3962441c0 ("virtio_net: xsk: rx: support fill with xsk buffer")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: mst@...hat.com
> CC: jasowang@...hat.com
> CC: xuanzhuo@...ux.alibaba.com
> CC: eperezma@...hat.com
> CC: hawk@...nel.org
> CC: john.fastabend@...il.com
> CC: virtualization@...ts.linux.dev
> CC: minhquangbui99@...il.com
> ---

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks