netdev - Re: [PATCH net] bnxt_en: fix module unload sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLiniEL5bcf7Zz1WD8PEZOaiLYNEzN5oT7fqCfB-10VNT8Q@mail.gmail.com>
Date: Wed, 30 Apr 2025 10:36:53 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Vadim Fedorenko <vadfed@...a.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Pavan Chebbi <pavan.chebbi@...adcom.com>, 
	Jakub Kicinski <kuba@...nel.org>, Richard Cochran <richardcochran@...il.com>, 
	Taehee Yoo <ap420073@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: fix module unload sequence

On Wed, Apr 30, 2025 at 10:03 AM Vadim Fedorenko <vadfed@...a.com> wrote:
>
> Recent updates to the PTP part of bnxt changed the way PTP FIFO is
> cleared, skbs waiting for TX timestamps are now cleared during
> ndo_close() call. To do clearing procedure, the ptp structure must
> exist and point to a valid address. Module destroy sequence had ptp
> clear code running before netdev close causing invalid memory access and
> kernel crash. Change the sequence to destroy ptp structure after device
> close.
>
> Fixes: 8f7ae5a85137 ("bnxt_en: improve TX timestamping FIFO configuration")
> Reported-by: Taehee Yoo <ap420073@...il.com>
> Closes: https://lore.kernel.org/netdev/CAMArcTWDe2cd41=ub=zzvYifaYcYv-N-csxfqxUvejy_L0D6UQ@mail.gmail.com/
> Signed-off-by: Vadim Fedorenko <vadfed@...a.com>

The PTP destroy sequence is now consistent with bnxt_shutdown() and
bnxt_suspend().  Thanks.

Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4196 bytes)