netdev - Re: [Intel-wired-lan] [PATCH iwl-net] ixgbe: fix ndo_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1485d62-a746-4660-82d2-35965a349a34@linux.intel.com>
Date: Wed, 30 Apr 2025 10:55:25 +0200
From: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 intel-wired-lan@...ts.osuosl.org
Cc: netdev@...r.kernel.org, anthony.l.nguyen@...el.com,
 magnus.karlsson@...el.com, michal.kubiak@...el.com,
 Tobias Böhm <tobias.boehm@...zner-cloud.de>,
 Marcus Wichelmann <marcus.wichelmann@...zner-cloud.de>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ixgbe: fix ndo_xdp_xmit()
 workloads

On 2025-04-29 5:52 PM, Maciej Fijalkowski wrote:
> Currently ixgbe driver checks periodically in its watchdog subtask if
> there is anything to be transmitted (consdidering both Tx and XDP rings)

typo: s/consdidering/considering

> under state of carrier not being 'ok'. Such event is interpreted as Tx
> hang and therefore results in interface reset.
> 
> This is currently problematic for ndo_xdp_xmit() as it is allowed to
> produce descriptors when interface is going through reset or its carrier
> is turned off.
> 
> Furthermore, XDP rings should not really be objects of Tx hang
> detection. This mechanism is rather a matter of ndo_tx_timeout() being
> called from dev_watchdog against Tx rings exposed to networking stack.
> 
> Taking into account issues described above, let us have a two fold fix -
> do not respect XDP rings in local ixgbe watchdog and do not produce Tx
> descriptors in ndo_xdp_xmit callback when there is some problem with
> carrier currently. For now, keep the Tx hang checks in clean Tx irq
> routine, but adjust it to not execute it for XDP rings.

suggestion: s/adjust it to not execute it/adjust it to not execute

Best regards,
Dawid