netdev - Re: [PATCH v4 01/15] x86/msr: Add missing includes of <asm/msr.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5b7edab-1872-45ff-8f2e-bcb34f6bdc23@zytor.com>
Date: Wed, 30 Apr 2025 02:12:19 -0700
From: Xin Li <xin@...or.com>
To: Michael Kelley <mhklinux@...look.com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "jgross@...e.com" <jgross@...e.com>,
        "andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" <alexander.shishkin@...ux.intel.com>,
        "jolsa@...nel.org" <jolsa@...nel.org>,
        "irogers@...gle.com" <irogers@...gle.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "kan.liang@...ux.intel.com" <kan.liang@...ux.intel.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "ajay.kaher@...adcom.com" <ajay.kaher@...adcom.com>,
        "bcm-kernel-feedback-list@...adcom.com"
 <bcm-kernel-feedback-list@...adcom.com>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "luto@...nel.org"
 <luto@...nel.org>,
        "boris.ostrovsky@...cle.com"
 <boris.ostrovsky@...cle.com>,
        "kys@...rosoft.com" <kys@...rosoft.com>,
        "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
        "decui@...rosoft.com" <decui@...rosoft.com>,
        "dapeng1.mi@...ux.intel.com" <dapeng1.mi@...ux.intel.com>
Subject: Re: [PATCH v4 01/15] x86/msr: Add missing includes of <asm/msr.h>

On 4/29/2025 9:20 PM, Michael Kelley wrote:
>> Also under hyperv/ not all files are covered but I'm a bit hesitant to
>> suggest a change there since I'm not sure if they (hypervisors) do
>> something special w.r.t. msr.
> I've worked on the Hyper-V code in Linux for 8 years or so, first as
> a Microsoft employee, and more recently as a retiree. 🙂 I'm not
> aware of anything special w.r.t. MSR access for Hyper-V guests.
> All the normal Linux code for accessing MSRs just works. Hyper-V
> *does* provide a set of synthetic MSRs that are unique to
> Hyper-V, but they are also accessed using normal Linux code. Of
> course, at runtime the access to these synthetic MSRs always
> traps to the hypervisor.
> 
> I'm planning to apply Xin Li's patch set and make sure nothing
> breaks for Hyper-V guests, and particularly when running as an
> SEV-SNP or TDX guest. Hopefully I can do that by early next week
> at the latest.

Hi Michael, I appreciate it!