netdev - RE: [PATCH v3 01/15] ice: move TSPLL functions to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB50894D00F52F81FC4B257007D6822@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Thu, 1 May 2025 17:05:08 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, netdev
	<netdev@...r.kernel.org>, Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>
CC: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "Loktionov,
 Aleksandr" <aleksandr.loktionov@...el.com>, "Olech, Milena"
	<milena.olech@...el.com>, "Kubiak, Michal" <michal.kubiak@...el.com>,
	"Kolacinski, Karol" <karol.kolacinski@...el.com>
Subject: RE: [PATCH v3 01/15] ice: move TSPLL functions to a separate file



> -----Original Message-----
> From: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Sent: Thursday, May 1, 2025 10:03 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>; netdev <netdev@...r.kernel.org>;
> Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>
> Cc: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Loktionov, Aleksandr
> <aleksandr.loktionov@...el.com>; Olech, Milena <milena.olech@...el.com>;
> Kubiak, Michal <michal.kubiak@...el.com>; Kolacinski, Karol
> <karol.kolacinski@...el.com>
> Subject: Re: [PATCH v3 01/15] ice: move TSPLL functions to a separate file
> 
> 
> 
> On 4/30/2025 3:51 PM, Jacob Keller wrote:
> > From: Karol Kolacinski <karol.kolacinski@...el.com>
> >
> > Collect TSPLL related functions and definitions and move them to
> > a separate file to have all TSPLL functionality in one place.
> 
> I mentioned in one of the earlier versions that this lost/reverted
> commit 4c9f13a65426 ("ice: use string choice helpers"), we should
> restore that. That will trickle some adjustments into the later patches
> as well i.e. use helper over open coding.
> 
> Thanks,
> Tony
> 

Ahh.. Should have spotted that. Will fix in v4 with a rebase on top of the IWL to handle the issues with libie adminq changes as well.

> > Move CGU related functions and definitions to ice_common.*
> >
> > Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>
> > Reviewed-by: Milena Olech <milena.olech@...el.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
>