[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250501071518.50c92e8c@kernel.org>
Date: Thu, 1 May 2025 07:15:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org, Simon Horman
<horms@...nel.org>, Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH net v4] net: airoha: Add missing filed to ppe_mbox_data
struct
On Tue, 29 Apr 2025 16:17:41 +0200 Lorenzo Bianconi wrote:
> Moreover, add __packed attribute to ppe_mbox_data struct definition and
> make the fw layout padding explicit in init_info struct.
Why? everything looks naturally packed now :(
__packed also forces the compiler to assume the data is unaligned AFAIU.
The recommended way to ensure the compiler doesn't insert padding is
to do a compile time assert.
Powered by blists - more mailing lists