netdev - Re: [PATCH RFC v2 4/6] coredump: show supported coredump modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250502-zugrunde-mehrheit-5fc9ef5d6ec8@brauner>
Date: Fri, 2 May 2025 22:11:22 +0200
From: Christian Brauner <brauner@...nel.org>
To: Jann Horn <jannh@...gle.com>
Cc: Eric Dumazet <edumazet@...gle.com>, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, Oleg Nesterov <oleg@...hat.com>, linux-fsdevel@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, Alexander Viro <viro@...iv.linux.org.uk>, 
	Daan De Meyer <daan.j.demeyer@...il.com>, David Rheinsberg <david@...dahead.eu>, 
	Jakub Kicinski <kuba@...nel.org>, Jan Kara <jack@...e.cz>, 
	Lennart Poettering <lennart@...ttering.net>, Luca Boccassi <bluca@...ian.org>, Mike Yuan <me@...dnzj.com>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH RFC v2 4/6] coredump: show supported coredump modes

On Fri, May 02, 2025 at 04:07:23PM +0200, Jann Horn wrote:
> On Fri, May 2, 2025 at 2:43 PM Christian Brauner <brauner@...nel.org> wrote:
> > Allow userspace to discover what coredump modes are supported.
> >
> > Signed-off-by: Christian Brauner <brauner@...nel.org>
> > ---
> >  fs/coredump.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/fs/coredump.c b/fs/coredump.c
> > index 9a6cba233db9..1c7428c23878 100644
> > --- a/fs/coredump.c
> > +++ b/fs/coredump.c
> > @@ -1217,6 +1217,13 @@ static int proc_dostring_coredump(const struct ctl_table *table, int write,
> >
> >  static const unsigned int core_file_note_size_min = CORE_FILE_NOTE_SIZE_DEFAULT;
> >  static const unsigned int core_file_note_size_max = CORE_FILE_NOTE_SIZE_MAX;
> > +static char core_modes[] = {
> > +#ifdef CONFIG_UNIX
> > +       "file\npipe\nunix"
> > +#else
> > +       "file\npipe"
> > +#endif
> > +};
> 
> Nit: You could do something like
> 
> static char core_modes[] =
> #ifdef CONFIG_UNIX
>   "unix\n"
> #endif
>   "file\npipe"
> ;

Thanks!