netdev - Re: [PATCH bpf-next/net v2 4/5] selftests/bpf: Test attaching a bpf qdisc with incomplete operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8fdecc9c-e1ac-4c75-9382-3d6fdd760350@linux.dev>
Date: Fri, 2 May 2025 16:54:06 -0700
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Amery Hung <ameryhung@...il.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org,
 alexei.starovoitov@...il.com, andrii@...nel.org, daniel@...earbox.net,
 martin.lau@...nel.org, xiyou.wangcong@...il.com, kernel-team@...a.com
Subject: Re: [PATCH bpf-next/net v2 4/5] selftests/bpf: Test attaching a bpf
 qdisc with incomplete operators

On 5/2/25 1:16 PM, Amery Hung wrote:
> +SEC("struct_ops/bpf_qdisc_test_enqueue")
> +SEC("struct_ops/bpf_qdisc_test_dequeue")
> +SEC("struct_ops/bpf_qdisc_test_reset")
> +SEC("struct_ops/bpf_qdisc_test_destroy")

I removed all the "/bpf_qdisc_test_xxx" part. Only SEC("struct_ops") is needed. 
A similar cleanup was done in bpf_cubic/dctcp.c.

> +SEC("struct_ops/bpf_fifo_destroy")
> +SEC("struct_ops/bpf_fq_destroy")

Removed the "/bpf_xxx" part from these new ones also.

The other existing bpf_qdisc_fifo/fq SEC was an overlook and it should be 
cleaned up in a followup.

Applied. Thanks.