netdev - Re: [PATCH net v4] net: airoha: Add missing filed to ppe_mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBRzQaonAK0IyAsu@lore-desk>
Date: Fri, 2 May 2025 09:24:49 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
	Simon Horman <horms@...nel.org>,
	Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH net v4] net: airoha: Add missing filed to ppe_mbox_data
 struct

> On Thu, 1 May 2025 22:47:06 +0200 Lorenzo Bianconi wrote:
> > On May 01, Jakub Kicinski wrote:
> > > On Tue, 29 Apr 2025 16:17:41 +0200 Lorenzo Bianconi wrote:  
> > > > Moreover, add __packed attribute to ppe_mbox_data struct definition and
> > > > make the fw layout padding explicit in init_info struct.  
> > > 
> > > Why? everything looks naturally packed now :(  
> > 
> > What I mean here is the padding in the ppe_mbox_data struct used by the fw running
> > on the NPU, not in the version used by the airoha_eth driver, got my point?
> > Sorry, re-reading it, it was not so clear, I agree.
> 
> You mean adding the "u8 rsv[3];" ? that is fine.
> I don't get why we also need to add the 3 __packed

I agree the __packed attributes are not mandatory at the moment, we just agreed
with Jacob that is fine to add them. Do you prefer to get rid of them?

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)