lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aBR_1oQN-gKCREBD@gmail.com>
Date: Fri, 2 May 2025 10:18:30 +0200
From: Ingo Molnar <mingo@...nel.org>
To: "Xin Li (Intel)" <xin@...or.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	linux-perf-users@...r.kernel.org, linux-hyperv@...r.kernel.org,
	virtualization@...ts.linux.dev, linux-pm@...r.kernel.org,
	linux-edac@...r.kernel.org, xen-devel@...ts.xenproject.org,
	linux-acpi@...r.kernel.org, linux-hwmon@...r.kernel.org,
	netdev@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
	dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
	acme@...nel.org, jgross@...e.com, andrew.cooper3@...rix.com,
	peterz@...radead.org, namhyung@...nel.org, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com, wei.liu@...nel.org,
	ajay.kaher@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	tony.luck@...el.com, pbonzini@...hat.com, vkuznets@...hat.com,
	seanjc@...gle.com, luto@...nel.org, boris.ostrovsky@...cle.com,
	kys@...rosoft.com, haiyangz@...rosoft.com, decui@...rosoft.com,
	dapeng1.mi@...ux.intel.com, ilpo.jarvinen@...ux.intel.com
Subject: Re: [PATCH v4 02/15] x86/msr: Move rdtsc{,_ordered}() to <asm/tsc.h>


* Xin Li (Intel) <xin@...or.com> wrote:

> For some reason, there are some TSC-related functions in the MSR
  ^^^^^^^^^^^^^^^
> header even though there is a tsc.h header.

The real reason is that the rdtsc{,_ordered}() methods use the 
EAX_EDX_*() macros to optimize their EDX/EAX assembly accessors, which 
is why these methods were in <asm/msr.h>.

Your followup patch tacitly acknowledges this by silently creating 
duplicate copies of these facilities in both headers ...

I've cleaned it all up in tip:x86/msr via these preparatory patches:

  x86/msr: Improve the comments of the DECLARE_ARGS()/EAX_EDX_VAL()/EAX_EDX_RET() facility
  x86/msr: Rename DECLARE_ARGS() to EAX_EDX_DECLARE_ARGS
  x86/msr: Move the EAX_EDX_*() methods from <asm/msr.h> to <asm/asm.h>

Thanks,

	Ingo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ