netdev - Re: [PATCH net-next] eth: fbnic: fix `tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBWGQ_27ZI7Ti-Z5@LQ3V64L9R2>
Date: Fri, 2 May 2025 19:58:11 -0700
From: Joe Damato <jdamato@...tly.com>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, horms@...nel.org, vadim.fedorenko@...ux.dev,
	sdf@...ichev.me
Subject: Re: [PATCH net-next] eth: fbnic: fix `tx_dropped` counting

On Fri, May 02, 2025 at 07:01:45PM -0700, Mohsin Bashir wrote:
> Fix the tracking of rtnl_link_stats.tx_dropped. The counter
> `tmi.drop.frames` is being double counted whereas, the counter
> `tti.cm_drop.frames` is being skipped.
> 
> Fixes: f2957147ae7a ("eth: fbnic: add support for TTI HW stats")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_netdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Joe Damato <jdamato@...tly.com>