netdev - Re: [PATCH net-next v2] selftests: net: exit cleanly on SIGTERM / timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250502181320.562940c0@kernel.org>
Date: Fri, 2 May 2025 18:13:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Edward Cree <ecree.xilinx@...il.com>, davem@...emloft.net,
 netdev@...r.kernel.org, edumazet@...gle.com, andrew+netdev@...n.ch,
 horms@...nel.org, petrm@...dia.com, willemb@...gle.com, sdf@...ichev.me,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: exit cleanly on SIGTERM /
 timeout

On Fri, 2 May 2025 15:05:48 +0200 Paolo Abeni wrote:
> >> @@ -229,11 +249,12 @@ KSFT_DISRUPTIVE = True
> >>              cnt_key = 'xfail'
> >>          except BaseException as e:
> >>              stop |= isinstance(e, KeyboardInterrupt)
> >> +            stop |= isinstance(e, KsftTerminate)  
> > 
> > The first isinstance() will return True for a KsftTerminate as it's a
> >  subclass of KeyboardInterrupt, and thus the second line isn't needed.  
> 
> @Jakub: I'm using the selftests code to refresh my rather rusty python
> skills, I think it would be good to address the above and keep the
> codebase clean.

Right, right, I was just distracted the last 3 days, wasn't trying 
to ignore :) Will respin shortly, good catch indeed.