netdev - Re: [PATCH net v4] net: airoha: Add missing filed to ppe_mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBXWSzhXv9RDiJ5L@lore-desk>
Date: Sat, 3 May 2025 10:39:39 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
	Simon Horman <horms@...nel.org>,
	Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH net v4] net: airoha: Add missing filed to ppe_mbox_data
 struct

On May 02, Jakub Kicinski wrote:
> On Fri, 2 May 2025 09:24:49 +0200 Lorenzo Bianconi wrote:
> > > > What I mean here is the padding in the ppe_mbox_data struct used by the fw running
> > > > on the NPU, not in the version used by the airoha_eth driver, got my point?
> > > > Sorry, re-reading it, it was not so clear, I agree.  
> > > 
> > > You mean adding the "u8 rsv[3];" ? that is fine.
> > > I don't get why we also need to add the 3 __packed  
> > 
> > I agree the __packed attributes are not mandatory at the moment, we just agreed
> > with Jacob that is fine to add them. Do you prefer to get rid of them?
> 
> Yes, they also imply the structure may not be aligned, AFAIU.
> __packed used to be one of DaveM's big no-nos back in the day.
> Especially in vendor drivers it gets sprinkled everywhere without
> thinking. So maybe it's all school of me, but yes, please remove.

ack, fine. I will get rid of them in v5.

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)