netdev - Re: [PATCH net-next v6 04/11] net: ti: prueth: Adds link detection, RX and TX support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6851d9ce-63d3-4c8f-bf43-935348998963@oracle.com>
Date: Sat, 3 May 2025 14:31:53 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Parvathi Pudi <parvathi@...thit.com>, danishanwar@...com,
        rogerq@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, nm@...com,
        ssantosh@...nel.org, tony@...mide.com, richardcochran@...il.com,
        glaroque@...libre.com, schnelle@...ux.ibm.com, m-karicheri2@...com,
        s.hauer@...gutronix.de, rdunlap@...radead.org, diogo.ivo@...mens.com,
        basharath@...thit.com, horms@...nel.org, jacob.e.keller@...el.com,
        m-malladi@...com, javier.carrasco.cruz@...il.com, afd@...com,
        s-anna@...com
Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        pratheesh@...com, prajith@...com, vigneshr@...com, praneeth@...com,
        srk@...com, rogerq@...com, krishna@...thit.com, pmohan@...thit.com,
        mohan@...thit.com
Subject: Re: [PATCH net-next v6 04/11] net: ti: prueth: Adds link detection,
 RX and TX support.



On 23-04-2025 12:53, Parvathi Pudi wrote:
> From: Roger Quadros <rogerq@...com>
> 
> Changes corresponding to link configuration such as speed and duplexity.
> IRQ and handler initializations are performed for packet reception.Firmware
> receives the packet from the wire and stores it into OCMC queue. Next, it
> notifies the CPU via interrupt. Upon receiving the interrupt CPU will
> service the IRQ and packet will be processed by pushing the newly allocated
> SKB to upper layers.
> 
> When the user application want to transmit a packet, it will invoke
> sys_send() which will inturn invoke the PRUETH driver, then it will write

typo in turn

> the packet into OCMC queues. PRU firmware will pick up the packet and
> transmit it on to the wire.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> Signed-off-by: Andrew F. Davis <afd@...com>
> Signed-off-by: Basharath Hussain Khaja <basharath@...thit.com>
> Signed-off-by: Parvathi Pudi <parvathi@...thit.com>
> ---
[clip]
> +}
> +
> +/**
> + * icssm_emac_ndo_start_xmit - EMAC Transmit function
> + * @skb: SKB pointer
> + * @ndev: EMAC network adapter
> + *
> + * Called by the system to transmit a packet  - we queue the packet in

remove extra ' ' after packet

> + * EMAC hardware transmit queue
> + *
> + * Return: enum netdev_tx
> + */
> +static enum netdev_tx icssm_emac_ndo_start_xmit(struct sk_buff *skb,
> +						struct net_device *ndev)
> +{
> +	struct prueth_emac *emac = netdev_priv(ndev);
> +	int ret;


Thanks,
Alok