[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c890cd3b-a4c5-217d-3ad3-6d9389b98f7c@intel.com>
Date: Sun, 4 May 2025 12:13:44 +0300
From: "Lifshits, Vitaly" <vitaly.lifshits@...el.com>
To: Jacek Kowalski <jacek@...ekk.info>, Simon Horman <horms@...nel.org>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp
when valid checksum mask is not set
On 4/28/2025 7:43 PM, Jacek Kowalski wrote:
>> Anyway, I think that the commit message should be precise.
>> How about this?
>>
>> Starting from Tiger Lake, LAN NVM is locked for writes by SW, so the
>> driver cannot perform checksum validation and correction. This means
>> that all NVM images must leave the factory with correct checksum and
>> checksum valid bit set. Since Tiger Lake devices were the first to
>> have this lock, some systems in the field did not meet this
>> requirement. Therefore, for these transitional devices we skip
>> checksum update and verification, if the valid bit is not set.
>
> Should I prepare v2 with this description?
>
Yes, please.
Powered by blists - more mailing lists