netdev - Re: [PATCH net] ice: use DSN instead of PCI BDF for ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <of7mx4pyyka2rx7oauukv6jbtvcphj2uofblqugdrplgy4ki6n@tnyct3vzqdae>
Date: Mon, 5 May 2025 18:35:14 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	edumazet@...gle.com, andrew+netdev@...n.ch, netdev@...r.kernel.org, 
	Przemek Kitszel <przemyslaw.kitszel@...el.com>, karol.kolacinski@...el.com, sergey.temerkhanov@...el.com, 
	michal.kubiak@...el.com, aleksandr.loktionov@...el.com, jacob.e.keller@...el.com, 
	mschmidt@...hat.com, horms@...nel.org, Rinitha S <sx.rinitha@...el.com>
Subject: Re: [PATCH net] ice: use DSN instead of PCI BDF for ice_adapter index

Mon, May 05, 2025 at 06:19:38PM +0200, anthony.l.nguyen@...el.com wrote:
>From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>
>Use Device Serial Number instead of PCI bus/device/function for
>the index of struct ice_adapter.
>
>Functions on the same physical device should point to the very same
>ice_adapter instance, but with two PFs, when at least one of them is
>PCI-e passed-through to a VM, it is no longer the case - PFs will get
>seemingly random PCI BDF values, and thus indices, what finally leds to
>each of them being on their own instance of ice_adapter. That causes them
>to don't attempt any synchronization of the PTP HW clock usage, or any
>other future resources.
>
>DSN works nicely in place of the index, as it is "immutable" in terms of
>virtualization.
>
>Fixes: 0e2bddf9e5f9 ("ice: add ice_adapter for shared data across PFs on the same NIC")
>Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
>Suggested-by: Jakub Kicinski <kuba@...nel.org>
>Suggested-by: Jiri Pirko <jiri@...nulli.us>
>Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
>Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>Reviewed-by: Simon Horman <horms@...nel.org>
>Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)
>Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>