| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aBhvNfWP-Rmec3Ci@soc-5CG4396X81.clients.intel.com>
Date: Mon, 5 May 2025 09:56:37 +0200
From: Larysa Zaremba <larysa.zaremba@...el.com>
To: Simon Horman <horms@...nel.org>
CC: Jacob Keller <jacob.e.keller@...el.com>,
<intel-wired-lan@...ts.osuosl.org>, Tony Nguyen <anthony.l.nguyen@...el.com>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Jonathan
Corbet" <corbet@....net>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
"Jiri Pirko" <jiri@...nulli.us>, Tatyana Nikolova
<tatyana.e.nikolova@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>,
Alexander Lobakin <aleksander.lobakin@...el.com>, Michael Ellerman
<mpe@...erman.id.au>, "Maciej Fijalkowski" <maciej.fijalkowski@...el.com>,
Lee Trager <lee@...ger.us>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
Sridhar Samudrala <sridhar.samudrala@...el.com>, Michal Swiatkowski
<michal.swiatkowski@...ux.intel.com>, Mateusz Polchlopek
<mateusz.polchlopek@...el.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
<netdev@...r.kernel.org>, <linux-doc@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, "Karlsson, Magnus"
<magnus.karlsson@...el.com>, Emil Tantilov <emil.s.tantilov@...el.com>,
"Madhu Chittim" <madhu.chittim@...el.com>, Josh Hay <joshua.a.hay@...el.com>,
"Milena Olech" <milena.olech@...el.com>, <pavan.kumar.linga@...el.com>,
"Singhai, Anjali" <anjali.singhai@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 01/14] virtchnl: create
'include/linux/intel' and move necessary header files
On Wed, Apr 30, 2025 at 09:55:45AM +0100, Simon Horman wrote:
> On Tue, Apr 29, 2025 at 11:47:58AM -0700, Jacob Keller wrote:
> >
> >
> > On 4/28/2025 9:15 AM, Simon Horman wrote:
> > > On Thu, Apr 24, 2025 at 01:32:24PM +0200, Larysa Zaremba wrote:
> > >> From: Victor Raj <victor.raj@...el.com>
> > >>
> > >> Move intel specific header files into new folder
> > >> include/linux/intel.
> > >>
> > >> Suggested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> > >> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> > >> Signed-off-by: Victor Raj <victor.raj@...el.com>
> > >> Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
> > >> ---
> > >> MAINTAINERS | 6 +++---
> > >> drivers/infiniband/hw/irdma/i40iw_if.c | 2 +-
> > >> drivers/infiniband/hw/irdma/main.h | 2 +-
> > >> drivers/infiniband/hw/irdma/osdep.h | 2 +-
> > >> drivers/net/ethernet/intel/i40e/i40e.h | 4 ++--
> > >> drivers/net/ethernet/intel/i40e/i40e_client.c | 2 +-
> > >> drivers/net/ethernet/intel/i40e/i40e_common.c | 2 +-
> > >> drivers/net/ethernet/intel/i40e/i40e_prototype.h | 2 +-
> > >> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
> > >> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h | 2 +-
> > >> drivers/net/ethernet/intel/iavf/iavf.h | 2 +-
> > >> drivers/net/ethernet/intel/iavf/iavf_common.c | 2 +-
> > >> drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
> > >> drivers/net/ethernet/intel/iavf/iavf_prototype.h | 2 +-
> > >> drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +-
> > >> drivers/net/ethernet/intel/iavf/iavf_types.h | 4 +---
> > >> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +-
> > >> drivers/net/ethernet/intel/ice/ice.h | 2 +-
> > >> drivers/net/ethernet/intel/ice/ice_common.h | 2 +-
> > >> drivers/net/ethernet/intel/ice/ice_idc_int.h | 2 +-
> > >> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 2 +-
> > >> drivers/net/ethernet/intel/ice/ice_vf_lib.h | 2 +-
> > >> drivers/net/ethernet/intel/ice/ice_virtchnl.h | 2 +-
> > >> drivers/net/ethernet/intel/idpf/idpf.h | 2 +-
> > >> drivers/net/ethernet/intel/idpf/idpf_txrx.h | 2 +-
> > >> drivers/net/ethernet/intel/libie/rx.c | 2 +-
> > >> include/linux/{net => }/intel/i40e_client.h | 0
> > >> include/linux/{net => }/intel/iidc.h | 0
> > >> include/linux/{net => }/intel/libie/rx.h | 0
> > >> include/linux/{avf => intel}/virtchnl.h | 0
> > >> .../ethernet/intel/idpf => include/linux/intel}/virtchnl2.h | 0
> > >> .../intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h | 0
> > >> 32 files changed, 29 insertions(+), 31 deletions(-)
> > >> rename include/linux/{net => }/intel/i40e_client.h (100%)
> > >> rename include/linux/{net => }/intel/iidc.h (100%)
> > >> rename include/linux/{net => }/intel/libie/rx.h (100%)
> > >> rename include/linux/{avf => intel}/virtchnl.h (100%)
> > >> rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2.h (100%)
> > >> rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h (100%)
> > >>
> > >> diff --git a/MAINTAINERS b/MAINTAINERS
> > >> index 657a67f9031e..2e2a57dfea8f 100644
> > >> --- a/MAINTAINERS
> > >> +++ b/MAINTAINERS
> > >> @@ -11884,8 +11884,8 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
> > >> F: Documentation/networking/device_drivers/ethernet/intel/
> > >> F: drivers/net/ethernet/intel/
> > >> F: drivers/net/ethernet/intel/*/
> > >> -F: include/linux/avf/virtchnl.h
> > >> -F: include/linux/net/intel/iidc.h
> > >> +F: include/linux/intel/iidc.h
> > >> +F: include/linux/intel/virtchnl.h
> > >
> > > I'm not sure that I understand the motivation for moving files out of
> > > include/linux/net, but I guess the answer is that my suggestion, which
> > > would be to move files into include/linux/net, is somehow less good.
> > >
> > > But if file are moving out of include/linux/net then I think it would
> > > make sense to make a corresponding update to NETWORKING DRIVERS.
> > >
> > > Also, include/linux/intel, does feel a bit too general. These files
> > > seem to relate to NICs (of some sort of flavour or another). But Intel
> > > does a lot more than make NICs.
> > >
> >
> > 'include/linux/net/intel' seems fine to me. I agree with moving
> > virtchnl.h there since it is quite clear that any historical ambitions
> > about AVF being vendor agnostic are long dead, so having it in its own
> > 'non-intel' folder is silly.
> >
> > Strictly speaking, I think the goal of moving the files is due to the
> > fact that a lot of the core ixd code is not really network layer but
> > instead PCI layer.
>
> Sure. I was more thinking out loud in my previous email than requesting any
> action. Thanks for filling in my understanding of the situation.
>
Olek suggested this because intel was the only resident in include/linux/net and
include/linux/intel was vacant.
> But could we please consider updating NETWORKING DRIVERS so
> that get_maintainers.pl can help people to CC netdev and it's maintainers
> as appropriate?
I am not sure what kind of update do you mean, include/linux/net directory was
not under any maintainer. include/linux/mlx5 and include/linux/mlx4 are only
under vendor maintainers.
For sure I should add include/linux/intel/* under Tony.
Do you think it also should be added to general networking maintainers?
Powered by blists - more mailing lists