netdev - Re: [PATCH net-next 2/5] net: vertexcom: mse102x: Add warning about IRQ trigger type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9633874-a41c-4f62-9b80-33785c0eec10@lunn.ch>
Date: Tue, 6 May 2025 14:24:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Stefan Wahren <wahrenst@....net>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 2/5] net: vertexcom: mse102x: Add warning about
 IRQ trigger type

On Tue, May 06, 2025 at 10:38:53AM +0200, Stefan Wahren wrote:
> Hi Andrew,
> 
> Am 05.05.25 um 18:32 schrieb Andrew Lunn:
> > > +	if (!irq_data) {
> > > +		netdev_err(ndev, "Invalid IRQ: %d\n", ndev->irq);
> > > +		return -EINVAL;
> > > +	}
> > > +
> > > +	switch (irqd_get_trigger_type(irq_data)) {
> > > +	case IRQ_TYPE_LEVEL_HIGH:
> > > +	case IRQ_TYPE_LEVEL_LOW:
> > > +		break;
> > > +	default:
> > > +		netdev_warn_once(ndev, "Only IRQ type level recommended, please update your firmware.\n");
> > I would probably put DT in there somewhere. firmware is rather
> > generic.
> I'm fine with changing it to DT. I slightly remember of a patch for a
> BCM2835 driver, which also had a warning to update the DT and a reviewer
> requested it to change it to firmware. I don't remember the reason behind
> it, maybe it's the fact that not all user know what a DT / devicetree is. A
> quick grep shows both variants (DT vs firmware).


The line gets long, but "Only IRQ type level recommended, please
update your device tree firmware.\n" is good for me.

	Andrew