netdev - Re: [PATCH v28 00/20] nvme-tcp receive offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f1e9f1b-ace9-46d1-96bb-3a117d676c90@grimberg.me>
Date: Tue, 6 May 2025 16:34:42 +0300
From: Sagi Grimberg <sagi@...mberg.me>
To: Keith Busch <kbusch@...nel.org>, Jakub Kicinski <kuba@...nel.org>
Cc: Gustavo Padovan <gus@...labora.com>, Aurelien Aptel <aaptel@...dia.com>,
 linux-nvme <linux-nvme@...ts.infradead.org>, netdev
 <netdev@...r.kernel.org>, hch <hch@....de>, axboe <axboe@...com>,
 chaitanyak <chaitanyak@...dia.com>, davem <davem@...emloft.net>,
 "aurelien.aptel" <aurelien.aptel@...il.com>, smalin <smalin@...dia.com>,
 malin1024 <malin1024@...il.com>, ogerlitz <ogerlitz@...dia.com>,
 yorayz <yorayz@...dia.com>, borisp <borisp@...dia.com>,
 galshalom <galshalom@...dia.com>, mgurtovoy <mgurtovoy@...dia.com>,
 tariqt <tariqt@...dia.com>, edumazet <edumazet@...gle.com>
Subject: Re: [PATCH v28 00/20] nvme-tcp receive offloads



On 06/05/2025 0:51, Keith Busch wrote:
> On Mon, May 05, 2025 at 01:43:34PM -0700, Jakub Kicinski wrote:
>> Looks like the tests passed? But we'll drop this from our PW, again.
>> Christoph Hellwig was pushing back on the v27. We can't do anything
>> with these until NVMe people are all happy.
> FWIW, I believe Sagi is okay with this as he has reviewed or acked all
> the patches. I am also okay with this, though I'm more or less neutral
> on the whole since it's outside my scope, but the nvme parts look fine.
> The new additions are isolated to hardware that provides these offloads,
> so I'm not really concerned this is going to be a problem maintaining
> with the existing nvme-tcp driver. I trust in Sagi on this one.

Yes, as I commented before, I'm perfectly fine with adding this.