netdev - RE: [PATCH net-next v2 00/11][pull request] idpf: add initial PTP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH7PR11MB588530D6A52A68552C859C298E89A@PH7PR11MB5885.namprd11.prod.outlook.com>
Date: Tue, 6 May 2025 14:50:36 +0000
From: "Olech, Milena" <milena.olech@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, "richardcochran@...il.com"
	<richardcochran@...il.com>
Subject: RE: [PATCH net-next v2 00/11][pull request] idpf: add initial PTP
 support

On 05/05/2025 9:02 PM, Jakub Kicinski wrote:

>On Mon, 5 May 2025 17:20:11 +0000 Olech, Milena wrote:
>> >Right, nothing too obvious, maybe cross timestmaping. But it takes me 
>> >30min to just read the code, before I start finding bugs I have to 
>> >switch to doing something else:(
>> >
>> >It's not a deal breaker, but I keep trickling in review comments 2 at 
>> >a time, please don't blame me, I'm doing my best :)
>> >  
>> 
>> To have fully-functional PTP support we'd need clock configuration + 
>> Tx/Rx timestamping, so it will be challenging to remove something 
>> logically :<
>> 
>> The only ideas that come to my mind are:
>
>No strong preference, but
>
>> - Remove tstamp statistics and create a separate patch for that
>
>yes
>
>> - Split PTP clock configuration (1) and Tx/Rx timestamping (2)
>
>no
>

Is it ok if I remove tstamp stats from this series ~50-60 lines, and
won't add more code (I mean get_ts_stats) ?