netdev - Re: [PATCH net 4/6] can: rockchip_canfd: rkcanfd_remove(): fix order of unregistration calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09889011-29f9-4a0d-9087-0bb4a135498d@intel.com>
Date: Tue, 6 May 2025 11:29:12 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>, <netdev@...r.kernel.org>
CC: <davem@...emloft.net>, <kuba@...nel.org>, <linux-can@...r.kernel.org>,
	<kernel@...gutronix.de>, <stable@...r.kernel.org>, Markus Schneider-Pargmann
	<msp@...libre.com>
Subject: Re: [PATCH net 4/6] can: rockchip_canfd: rkcanfd_remove(): fix order
 of unregistration calls



On 5/6/2025 6:56 AM, Marc Kleine-Budde wrote:
> If a driver is removed, the driver framework invokes the driver's
> remove callback. A CAN driver's remove function calls
> unregister_candev(), which calls net_device_ops::ndo_stop further down
> in the call stack for interfaces which are in the "up" state.
> 
> The removal of the module causes a warning, as can_rx_offload_del()
> deletes the NAPI, while it is still active, because the interface is
> still up.
> 
> To fix the warning, first unregister the network interface, which
> calls net_device_ops::ndo_stop, which disables the NAPI, and then call
> can_rx_offload_del().
> 
> Fixes: ff60bfbaf67f ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
> Cc: stable@...r.kernel.org
> Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-2-59a9b131589d@pengutronix.de
> Reviewed-by: Markus Schneider-Pargmann <msp@...libre.com>
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>