netdev - Re: [net PATCH v2 6/8] fbnic: Improve responsiveness of fbnic_mbx_poll_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26002a53-0ae1-4c8f-830f-77ad018390c1@intel.com>
Date: Tue, 6 May 2025 11:54:29 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Alexander Duyck <alexander.duyck@...il.com>, <netdev@...r.kernel.org>
CC: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<horms@...nel.org>
Subject: Re: [net PATCH v2 6/8] fbnic: Improve responsiveness of
 fbnic_mbx_poll_tx_ready



On 5/6/2025 9:00 AM, Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@...com>
> 
> There were a couple different issues found in fbnic_mbx_poll_tx_ready.
> Among them were the fact that we were sleeping much longer than we actually
> needed to as the actual FW could respond in under 20ms. The other issue was
> that we would just keep polling the mailbox even if the device itself had
> gone away.
> 
> To address the responsiveness issues we can decrease the sleeps to 20ms and
> use a jiffies based timeout value rather than just counting the number of
> times we slept and then polled.
> 
> To address the hardware going away we can move the check for the firmware
> BAR being present from where it was and place it inside the loop after the
> mailbox descriptor ring is initialized and before we sleep so that we just
> abort and return an error if the device went away during initialization.
> 
> With these two changes we see a significant improvement in boot times for
> the driver.
> 
> Fixes: da3cde08209e ("eth: fbnic: Add FW communication mechanism")
> Signed-off-by: Alexander Duyck <alexanderduyck@...com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>