netdev - Re: [PATCH net v2] net: devmem: fix kernel panic when socket close after module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250506194233.281fa76d@kernel.org>
Date: Tue, 6 May 2025 19:42:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: Taehee Yoo <ap420073@...il.com>, davem@...emloft.net, pabeni@...hat.com,
 edumazet@...gle.com, andrew+netdev@...n.ch, horms@...nel.org,
 almasrymina@...gle.com, sdf@...ichev.me, netdev@...r.kernel.org,
 asml.silence@...il.com, dw@...idwei.uk, skhawaja@...gle.com,
 willemb@...gle.com, jdamato@...tly.com
Subject: Re: [PATCH net v2] net: devmem: fix kernel panic when socket close
 after module unload

On Tue, 6 May 2025 10:41:52 -0700 Stanislav Fomichev wrote:
> > +		mutex_unlock(&priv->lock);
> >  		netdev_unlock(dev);
> > +		netdev_put(dev, &dev_tracker);
> > +		mutex_lock(&priv->lock);  
> 
> nit: this feels like it deserves a comment on the lock ordering (and,
> hence, why this dance is needed). The rest looks good!

Agreed, and maybe document the ordering and what is protected 
in struct netdev_nl_sock ?