netdev - Re: [PATCH net-next v2 3/4] netlink: specs: remove implicit structs for SNMP counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m24ixwofn4.fsf@gmail.com>
Date: Wed, 07 May 2025 11:54:07 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com,  andrew+netdev@...n.ch,  horms@...nel.org,
  johannes@...solutions.net,  razor@...ckwall.org
Subject: Re: [PATCH net-next v2 3/4] netlink: specs: remove implicit structs
 for SNMP counters

Jakub Kicinski <kuba@...nel.org> writes:

> uAPI doesn't define structs for the SNMP counters, just enums to index
> them as arrays. Switch to the same representation in the spec. C codegen
> will soon need all the struct types to actually exist.
>
> Note that the existing definition was broken, anyway, as the first
> member should be the number of counters reported.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>