netdev - Re: [PATCH net] net: qede: Initialize qede_ll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <198CC0C3-5009-47B5-AE6A-B43A9D2EB126@kernel.org>
Date: Wed, 07 May 2025 17:58:26 -0700
From: Kees Cook <kees@...nel.org>
To: Nathan Chancellor <nathan@...nel.org>, Manish Chopra <manishc@...vell.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
CC: Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
 Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
 stable@...r.kernel.org
Subject: Re: [PATCH net] net: qede: Initialize qede_ll_ops with designated initializer

On May 7, 2025 1:47:45 PM PDT, Nathan Chancellor <nathan@...nel.org> wrote:
>After a recent change [1] in clang's randstruct implementation to
>randomize structures that only contain function pointers, there is an
>error because qede_ll_ops get randomized but does not use a designated
>initializer for the first member:
>
>  drivers/net/ethernet/qlogic/qede/qede_main.c:206:2: error: a randomized struct can only be initialized with a designated initializer
>    206 |         {
>        |         ^
>
>Explicitly initialize the common member using a designated initializer
>to fix the build.
>
>Cc: stable@...r.kernel.org
>Fixes: 035f7f87b729 ("randstruct: Enable Clang support")
>Link: https://github.com/llvm/llvm-project/commit/04364fb888eea6db9811510607bed4b200bcb082 [1]
>Signed-off-by: Nathan Chancellor <nathan@...nel.org>
>---
> drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +-

Oops, I missed this one with its 1-character different filename. 😅

Reviewed-by: Kees Cook <kees@...nel.org>

> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
>index 99df00c30b8c..b5d744d2586f 100644
>--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
>+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
>@@ -203,7 +203,7 @@ static struct pci_driver qede_pci_driver = {
> };
> 
> static struct qed_eth_cb_ops qede_ll_ops = {
>-	{
>+	.common = {
> #ifdef CONFIG_RFS_ACCEL
> 		.arfs_filter_op = qede_arfs_filter_op,
> #endif
>
>---
>base-commit: 9540984da649d46f699c47f28c68bbd3c9d99e4c
>change-id: 20250507-qede-fix-clang-randstruct-13d8c593cb58
>
>Best regards,

-- 
Kees Cook