[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250508090445.3b235bcc@kernel.org>
Date: Thu, 8 May 2025 09:04:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Cosmin Ratiu <cratiu@...dia.com>, Stanislav Fomichev <sdf@...ichev.me>
Cc: <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>, Eric
Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
Horman <horms@...nel.org>, Saeed Mahameed <saeedm@...dia.com>, Tariq Toukan
<tariqt@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net v2] net: Lock lower level devices when updating
features
On Thu, 8 May 2025 17:54:59 +0300 Cosmin Ratiu wrote:
> lower->wanted_features &= ~feature;
> + netdev_lock_ops(lower);
> __netdev_update_features(lower);
> + netdev_unlock_ops(lower);
>
> if (unlikely(lower->features & feature))
I'd be slightly tempted to try to cover the accesses to members of
lower, because why not:
netdev_lock_ops(lower);
lower->wanted_features &= ~feature;
__netdev_update_features(lower);
still_enabled = lower->features & feature;
netdev_unlock_ops(lower);
if (unlikely(still_enabled))
WDYT?
Powered by blists - more mailing lists