netdev - Re: [PATCH net] tools/net/ynl: ethtool: fix crash when Hardware Clock info is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBzYPU32tTu8_hXk@mini-arch>
Date: Thu, 8 May 2025 09:13:49 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Donald Hunter <donald.hunter@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Jan Stancek <jstancek@...hat.com>,
	Stanislav Fomichev <sdf@...ichev.me>
Subject: Re: [PATCH net] tools/net/ynl: ethtool: fix crash when Hardware
 Clock info is missing

On 05/08, Hangbin Liu wrote:
> Fix a crash in the ethtool YNL implementation when Hardware Clock information
> is not present in the response. This ensures graceful handling of devices or
> drivers that do not provide this optional field. e.g.
> 
>   Traceback (most recent call last):
>     File "/net/tools/net/ynl/pyynl/./ethtool.py", line 438, in <module>
>       main()
>       ~~~~^^
>     File "/net/tools/net/ynl/pyynl/./ethtool.py", line 341, in main
>       print(f'PTP Hardware Clock: {tsinfo["phc-index"]}')
>                                    ~~~~~~^^^^^^^^^^^^^
>   KeyError: 'phc-index'
> 
> Fixes: f3d07b02b2b8 ("tools: ynl: ethtool testing tool")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Acked-by: Stanislav Fomichev <sdf@...ichev.me>