netdev - Re: [PATCH v14 03/22] cxl: move pci generic code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f7ec84e-9df0-4753-97d2-91e6ee773091@intel.com>
Date: Thu, 8 May 2025 10:20:44 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Alejandro Lucero Palau <alucerop@....com>,
 Alison Schofield <alison.schofield@...el.com>, alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 Ben Cheatham <benjamin.cheatham@....com>, Fan Ni <fan.ni@...sung.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v14 03/22] cxl: move pci generic code



On 5/8/25 5:45 AM, Alejandro Lucero Palau wrote:
> 
> On 5/8/25 01:36, Alison Schofield wrote:
>> On Thu, Apr 17, 2025 at 10:29:06PM +0100, alejandro.lucero-palau@....com wrote:
>>> From: Alejandro Lucero <alucerop@....com>
>>>
>>> Inside cxl/core/pci.c there are helpers for CXL PCIe initialization
>>> meanwhile cxl/pci.c implements the functionality for a Type3 device
>>> initialization.
>>>
>>> Move helper functions from cxl/pci.c to cxl/core/pci.c in order to be
>>> exported and shared with CXL Type2 device initialization.
>>>
>>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>>> Reviewed-by: Ben Cheatham <benjamin.cheatham@....com>
>>> Reviewed-by: Fan Ni <fan.ni@...sung.com>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>>> ---
>>>   drivers/cxl/core/core.h       |  2 +
>>>   drivers/cxl/core/pci.c        | 62 +++++++++++++++++++++++++++++++
>>>   drivers/cxl/core/regs.c       |  1 -
>>>   drivers/cxl/cxl.h             |  2 -
>>>   drivers/cxl/cxlpci.h          |  2 +
>>>   drivers/cxl/pci.c             | 70 -----------------------------------
>>>   include/cxl/pci.h             | 13 +++++++
>>>   tools/testing/cxl/Kbuild      |  1 -
>>>   tools/testing/cxl/test/mock.c | 17 ---------
>> The commit log doesn't mention these cxl/test changes.
>> Why are these done?
> 
> 
> If I recall this right, moving the code has the effect of not requiring this code anymore.
> 
> 
> This comes from Dan's work for fixing the problem with that code moving.

I think what Alison is hinting at is to add a blurb in the commit log for the purpose of the cxl_test changes so a patch reader later on will have context of those changes.

DJ

> 
> 
>>
>>> index af2594e4f35d..3c6a071fbbe3 100644
>>> --- a/tools/testing/cxl/test/mock.c
>>> +++ b/tools/testing/cxl/test/mock.c
>>> @@ -268,23 +268,6 @@ struct cxl_dport *__wrap_devm_cxl_add_rch_dport(struct cxl_port *port,
>>>   }
>>>   EXPORT_SYMBOL_NS_GPL(__wrap_devm_cxl_add_rch_dport, "CXL");
>>>   -resource_size_t __wrap_cxl_rcd_component_reg_phys(struct device *dev,
>>> -                          struct cxl_dport *dport)
>>> -{
>>> -    int index;
>>> -    resource_size_t component_reg_phys;
>>> -    struct cxl_mock_ops *ops = get_cxl_mock_ops(&index);
>>> -
>>> -    if (ops && ops->is_mock_port(dev))
>>> -        component_reg_phys = CXL_RESOURCE_NONE;
>>> -    else
>>> -        component_reg_phys = cxl_rcd_component_reg_phys(dev, dport);
>>> -    put_cxl_mock_ops(index);
>>> -
>>> -    return component_reg_phys;
>>> -}
>>> -EXPORT_SYMBOL_NS_GPL(__wrap_cxl_rcd_component_reg_phys, "CXL");
>>> -
>>>   void __wrap_cxl_endpoint_parse_cdat(struct cxl_port *port)
>>>   {
>>>       int index;
>>> -- 
>>> 2.34.1
>>>
>>>