lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHS8izMkqMr6r6nYeDH9BgLWrf5_DsCibcg6-BcRhZiJQqiTyg@mail.gmail.com> Date: Thu, 8 May 2025 13:42:32 -0700 From: Mina Almasry <almasrymina@...gle.com> To: Cosmin Ratiu <cratiu@...dia.com> Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni <pabeni@...hat.com>, Joe Damato <jdamato@...tly.com>, Shuah Khan <shuah@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Saeed Mahameed <saeedm@...dia.com>, Tariq Toukan <tariqt@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>, linux-kselftest@...r.kernel.org Subject: Re: [PATCH net v2] tests/ncdevmem: Fix double-free of queue array On Thu, May 8, 2025 at 1:45 AM Cosmin Ratiu <cratiu@...dia.com> wrote: > > netdev_bind_rx takes ownership of the queue array passed as parameter > and frees it, so a queue array buffer cannot be reused across multiple > netdev_bind_rx calls. > > This commit fixes that by always passing in a newly created queue array > to all netdev_bind_rx calls in ncdevmem. > > Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP") > Signed-off-by: Cosmin Ratiu <cratiu@...dia.com> Thank you very much. Reviewed-by: Mina Almasry <almasrymina@...gle.com> Also, I think there was a discussion in v1 about increasing the amount of memory that ncdevmem uses by default (currently it's 64MB) as Stan suggested. I have it in my TODO list to implement that change but I don't think I'll get to it soon. If you (or anyone) gets to it before me, it's a welcome change. AFAIU it'll unblock you from running ncdevmem on your driver which expects much more dmabuf memory available. But to be clear, that can be a follow up change. I think this is good as-is. -- Thanks, Mina
Powered by blists - more mailing lists