netdev - Re: [PATCH net-next] selftests: net-drv: remove the nic_performance and nic_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f40402c-dbef-4eed-807c-dd0ea5438732@davidwei.uk>
Date: Thu, 8 May 2025 15:07:00 -0700
From: David Wei <dw@...idwei.uk>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org,
 willemb@...gle.com, sdf@...ichev.me, mohan.prasad@...rochip.com,
 petrm@...dia.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: net-drv: remove the nic_performance
 and nic_link_layer tests

On 5/7/25 07:01, Jakub Kicinski wrote:
> Revert fbbf93556f0c ("selftests: nic_performance: Add selftest for performance of NIC driver")
> Revert c087dc54394b ("selftests: nic_link_layer: Add selftest case for speed and duplex states")
> Revert 6116075e18f7 ("selftests: nic_link_layer: Add link layer selftest for NIC driver")
> 
> These tests don't clean up after themselves, don't use the disruptive
> annotations, don't get included in make install etc. etc. The tests
> were added before we have any "HW" runner, so the issues were missed.
> Our CI doesn't have any way of excluding broken tests, remove these
> for now to stop the random pollution of results due to broken env.
> We can always add them back once / if fixed.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: David Wei <dw@...idwei.uk>