netdev - RE: [PATCH net-next,rdma-next 5/5] iidc/ice/irdma: Update IDC to support multiple consumers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6194441ABE4D066DC8E0A4E4DD8BA@IA1PR11MB6194.namprd11.prod.outlook.com>
Date: Thu, 8 May 2025 23:20:15 +0000
From: "Ertman, David M" <david.m.ertman@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "jgg@...pe.ca"
	<jgg@...pe.ca>, "leon@...nel.org" <leon@...nel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nikolova, Tatyana E"
	<tatyana.e.nikolova@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [PATCH net-next,rdma-next 5/5] iidc/ice/irdma: Update IDC to
 support multiple consumers

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, May 7, 2025 7:43 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com;
> andrew+netdev@...n.ch; jgg@...pe.ca; leon@...nel.org; linux-
> rdma@...r.kernel.org; netdev@...r.kernel.org; Ertman, David M
> <david.m.ertman@...el.com>; Nikolova, Tatyana E
> <tatyana.e.nikolova@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: Re: [PATCH net-next,rdma-next 5/5] iidc/ice/irdma: Update IDC to
> support multiple consumers
> 
> On Mon,  5 May 2025 14:20:34 -0700 Tony Nguyen wrote:
> > -	pf->rdma_mode |= IIDC_RDMA_PROTOCOL_ROCEV2;
> > +	cdev->iidc_priv = privd;
> > +	privd->netdev = pf->vsi[0]->netdev;
> > +
> > +	privd->hw_addr = (u8 __iomem *)pf->hw.hw_addr;
> > +	cdev->pdev = pf->pdev;
> > +	privd->vport_id = pf->vsi[0]->vsi_num;
> > +
> > +	pf->cdev_info->rdma_protocol |= IIDC_RDMA_PROTOCOL_ROCEV2;
> > +	ice_setup_dcb_qos_info(pf, &privd->qos_info);
> >  	ret = ice_plug_aux_dev(pf);
> >  	if (ret)
> >  		goto err_plug_aux_dev;
> >  	return 0;
> >
> >  err_plug_aux_dev:
> > -	pf->adev = NULL;
> > +	pf->cdev_info->adev = NULL;
> >  	xa_erase(&ice_aux_id, pf->aux_idx);
> > +err_alloc_xa:
> > +	kfree(privd);
> > +err_privd_alloc:
> > +	kfree(cdev);
> > +	pf->cdev_info = NULL;
> 
> Where do privd and cdev get freed on normal device removal?

I literally smacked myself in the head for missing this first time through.

Thank you very much for the catch.  This should exist in ice_deinit_rdma
and a new version will be incoming.

DaveE