netdev - RE: [PATCH net-next v1 2/3] dpll: add reference sync get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ2PR11MB845242A2D576433DE5252F2C9B8AA@SJ2PR11MB8452.namprd11.prod.outlook.com>
Date: Fri, 9 May 2025 12:54:04 +0000
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "donald.hunter@...il.com" <donald.hunter@...il.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, "Dumazet,
 Eric" <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "Olech, Milena" <milena.olech@...el.com>
Subject: RE: [PATCH net-next v1 2/3] dpll: add reference sync get/set

>From: Simon Horman <horms@...nel.org>
>Sent: Monday, April 21, 2025 3:23 PM
>
>On Tue, Apr 15, 2025 at 07:51:14PM +0200, Arkadiusz Kubalewski wrote:
>> Define function for reference sync pin registration and callback ops to
>> set/get current feature state.
>>
>> Implement netlink handler to fill netlink messages with reference sync
>> pin configuration of capable pins (pin-get).
>>
>> Implement netlink handler to call proper ops and configure reference
>> sync pin state (pin-set).
>>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>> Reviewed-by: Milena Olech <milena.olech@...el.com>
>> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
>
>...
>
>> diff --git a/drivers/dpll/dpll_core.h b/drivers/dpll/dpll_core.h
>> index 2b6d8ef1cdf3..b77e021356ca 100644
>> --- a/drivers/dpll/dpll_core.h
>> +++ b/drivers/dpll/dpll_core.h
>> @@ -56,6 +56,7 @@ struct dpll_pin {
>>  	struct module *module;
>>  	struct xarray dpll_refs;
>>  	struct xarray parent_refs;
>> +	struct xarray sync_pins;
>
>nit: Please add sync_pins to the Kernel doc for struct dpll_pin.
>

True, fixed in v2.

>     And, separately, it would be quite nice if documentation
>     of the non-existent rclk_dev_name member removed too.

Sure will try to submit separated commit for this.

Thank you!
Arkadiusz

>
>>  	struct dpll_pin_properties prop;
>>  	refcount_t refcount;
>>  	struct rcu_head rcu;
>
>...