netdev - Re: [PATCH net-next v2] net: thunder: make tx software timestamp independent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <681e01ad26187_2b1da22945c@willemb.c.googlers.com.notmuch>
Date: Fri, 09 May 2025 09:22:53 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jason Xing <kerneljasonxing@...il.com>, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 horms@...nel.org, 
 sgoutham@...vell.com, 
 andrew+netdev@...n.ch, 
 willemb@...gle.com
Cc: linux-arm-kernel@...ts.infradead.org, 
 netdev@...r.kernel.org, 
 Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v2] net: thunder: make tx software timestamp
 independent

Jason Xing wrote:
> From: Jason Xing <kernelxing@...cent.com>
> 
> skb_tx_timestamp() is used for tx software timestamp enabled by
> SOF_TIMESTAMPING_TX_SOFTWARE while SKBTX_HW_TSTAMP is used for
> SOF_TIMESTAMPING_TX_HARDWARE. As it clearly shows they are different
> timestamps in two dimensions, it's not appropriate to group these two
> together in the if-statement.
> 
> This patch completes three things:
> 1. make the software one standalone. Users are able to set both
> timestamps together with SOF_TIMESTAMPING_OPT_TX_SWHW flag.
> 2. make the software one generated after the hardware timestamp logic to
> avoid generating sw and hw timestamps at one time without
> SOF_TIMESTAMPING_OPT_TX_SWHW being set.
> 3. move the software timestamp call as close to the door bell.
> 
> Signed-off-by: Jason Xing <kernelxing@...cent.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>