netdev - Re: [PATCH net-next V3 3/6] net: vertexcom: mse102x: Drop invalid cmd stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30a4dccc-3e7a-4829-b927-9b6298a1ac23@lunn.ch>
Date: Fri, 9 May 2025 15:41:44 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Stefan Wahren <wahrenst@....net>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH net-next V3 3/6] net: vertexcom: mse102x: Drop invalid
 cmd stats

On Fri, May 09, 2025 at 02:04:32PM +0200, Stefan Wahren wrote:
> There are several reasons for an invalid command response
> by the MSE102x:
> * SPI line interferences
> * MSE102x is in reset or has no firmware
> * MSE102x is busy
> * no packet in MSE102x receive buffer
> 
> So the counter for invalid command isn't very helpful without
> further context. So drop the confusing statistics counter,
> but keep the debug messages about "unexpected response" in order
> to debug possible hardware issues.
> 
> Signed-off-by: Stefan Wahren <wahrenst@....net>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew