netdev - Re: [PATCH net v2] tests/ncdevmem: Fix double-free of queue array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b7181f9866e357116e11d834040f6d927f6b201.camel@nvidia.com>
Date: Fri, 9 May 2025 07:24:57 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "almasrymina@...gle.com" <almasrymina@...gle.com>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "jdamato@...tly.com" <jdamato@...tly.com>, Tariq
 Toukan <tariqt@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>,
	"shuah@...nel.org" <shuah@...nel.org>, "sdf@...ichev.me" <sdf@...ichev.me>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net v2] tests/ncdevmem: Fix double-free of queue array

On Thu, 2025-05-08 at 13:42 -0700, Mina Almasry wrote:
> 
> Thank you very much.
> 
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>

Thank you for the review.

> 
> Also, I think there was a discussion in v1 about increasing the
> amount
> of memory that ncdevmem uses by default (currently it's 64MB) as Stan
> suggested. I have it in my TODO list to implement that change but I
> don't think I'll get to it soon. If you (or anyone) gets to it before
> me, it's a welcome change. AFAIU it'll unblock you from running
> ncdevmem on your driver which expects much more dmabuf memory
> available.
> 
> But to be clear, that can be a follow up change. I think this is good
> as-is.
> 

I do plan to follow-up on that topic, mlx5 will require some
reengineering to not fail rx rings refill when the pool is too small,
and most likely some touch-ups in ncdevmem/udmabuf to make this better.

Cosmin.