netdev - Re: [PATCH net-next] net: mlx4: add SOF_TIMESTAMPING_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d953d23-284b-4388-9421-89e0750cda7b@gmail.com>
Date: Sun, 11 May 2025 10:21:32 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jason Xing <kerneljasonxing@...il.com>, tariqt@...dia.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, willemdebruijn.kernel@...il.com
Cc: netdev@...r.kernel.org, Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next] net: mlx4: add SOF_TIMESTAMPING_TX_SOFTWARE flag
 when getting ts info



On 10/05/2025 12:34, Jason Xing wrote:
> From: Jason Xing <kernelxing@...cent.com>
> 
> As mlx4 has implemented skb_tx_timestamp() in mlx4_en_xmit(), the
> SOFTWARE flag is surely needed when users are trying to get timestamp
> information.
> 
> Signed-off-by: Jason Xing <kernelxing@...cent.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
> index cd17a3f4faf8..a68cd3f0304c 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
> @@ -1897,6 +1897,7 @@ static int mlx4_en_get_ts_info(struct net_device *dev,
>   	if (mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_TS) {
>   		info->so_timestamping |=
>   			SOF_TIMESTAMPING_TX_HARDWARE |
> +			SOF_TIMESTAMPING_TX_SOFTWARE |
>   			SOF_TIMESTAMPING_RX_HARDWARE |
>   			SOF_TIMESTAMPING_RAW_HARDWARE;
>   

Thanks for your patch.

Reviewed-by: Tariq Toukan <tariqt@...dia.com>