netdev - Re: [PATCH net-next] net: enetc: fix implicit declaration of function FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512111215.jljlwu2t5fc3kstc@skbuf>
Date: Mon, 12 May 2025 14:12:15 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Wei Fang <wei.fang@....com>
Cc: claudiu.manoil@....com, xiaoning.wang@....com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH net-next] net: enetc: fix implicit declaration of
 function FIELD_PREP

On Mon, May 12, 2025 at 02:17:01PM +0800, Wei Fang wrote:
> The kernel test robot reported the following error:
> 
> drivers/net/ethernet/freescale/enetc/ntmp.c: In function 'ntmp_fill_request_hdr':
> drivers/net/ethernet/freescale/enetc/ntmp.c:203:38: error: implicit
> declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
> 203 |         cbd->req_hdr.access_method = FIELD_PREP(NTMP_ACCESS_METHOD,
>     |                                      ^~~~~~~~~~
> 
> Therefore, add "bitfield.h" to ntmp_private.h to fix this issue.
> 
> Fixes: 4701073c3deb ("net: enetc: add initial netc-lib driver to support NTMP")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505101047.NTMcerZE-lkp@intel.com/
> Signed-off-by: Wei Fang <wei.fang@....com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>