netdev - Re: [PATCH net-next] net: ixp4xx_eth: convert to ndo_hwtstamp_get() and ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512120659.r7dmrugocat7ou3t@skbuf>
Date: Mon, 12 May 2025 15:06:59 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: netdev@...r.kernel.org,
	KÃ¶ry Maincent <kory.maincent@...tlin.com>,
	Linus Walleij <linusw@...nel.org>, Imre Kaloz <kaloz@...nwrt.org>,
	linux-arm-kernel@...ts.infradead.org, Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: ixp4xx_eth: convert to ndo_hwtstamp_get()
 and ndo_hwtstamp_set()

On Thu, May 08, 2025 at 11:45:48PM +0100, Vadim Fedorenko wrote:
> > The remainder of eth_ioctl() is exactly equivalent to
> > phy_do_ioctl_running(), so use that.
> 
> One interesting fact is that phy_do_ioctl_running() will return -ENODEV
> in case of !netif_running(netdev) while previous code would return
> -EINVAL. Probably it's ok, but may be it's better to have consistent
> error path for both options.
> 
> Otherwise LGTM,
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>

Thanks for the review. Indeed, I hadn't noticed the -EINVAL vs -ENODEV
difference.

Are you suggesting that I first create a patch which replaces -EINVAL
with -ENODEV in eth_ioctl(), so that ixp4xx_hwtstamp_get/set() is
consistent with phy_do_ioctl_running() in returning -ENODEV?