netdev - Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <98386cab-11c0-4f74-9925-8230af2e65c8@gmail.com>
Date: Mon, 12 May 2025 17:27:48 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 Jiri Pirko <jiri@...dia.com>, Gal Pressman <gal@...dia.com>,
 Leon Romanovsky <leonro@...dia.com>, Donald Hunter
 <donald.hunter@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 Jonathan Corbet <corbet@....net>, Saeed Mahameed <saeedm@...dia.com>,
 Leon Romanovsky <leon@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-rdma@...r.kernel.org, Moshe Shemesh <moshe@...dia.com>,
 Mark Bloch <mbloch@...dia.com>, Carolina Jubran <cjubran@...dia.com>,
 Cosmin Ratiu <cratiu@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
 Jason Gunthorpe <jgg@...pe.ca>, Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with
 traffic classes bandwidth management

On 09/05/2025 18:16, Jakub Kicinski wrote:
> On Fri, 9 May 2025 08:43:05 +0300 Tariq Toukan wrote:
>> +  -
>> +    name:  devlink-rate-tc-index-max
>> +    header: uapi/linux/devlink.h
>> +    type: const
>> +    value: 7

Hi Jakub,

> 
> Ugh, still wrong, the user space headers don't have uAPI in the path
> when installed. They go to /usr/include/linux/$name.h
> But for defines "local" to the family you don't have to specify header:
> at all, just drop it.
> 
> And please do build tests the next version:
> 
> 	make -C tools/net/ynl/ W=1 -j
> 

Noted.

> I'm going to also give you a hint that my next complaint will be that
> there are no selftests in this series, and it extends uAPI.

I have some questions, looking for answers in an official source.

Most importantly, it is unclear to me when a selftest is required. What 
is the guideline?

Please point me to any guidance for this selftest requirement. Is it 
generic, or networking subsystem specific?

Let's make sure these things are well-defined, so we plan the extra 
effort accordingly in future features, and improve predictability.

I reviewed
Documentation/process/maintainer-netdev.rst
Documentation/dev-tools/testing-overview.rst
Documentation/dev-tools/testing-devices.rst
Documentation/dev-tools/kselftest.rst
but couldn't find all answers.

BTW, some sources like the webpage link 
https://kselftest.wiki.kernel.org/ in 
Documentation/dev-tools/kselftest.rst is marked "OBSOLETE CONTENT". 
Should be totally ignored?

Also, should the selftests require vendor-specific hardware to run? or 
they imply adding netdevsim implementation?

Regards,
Tariq