netdev - Re: [PATCHv2 net-next 1/6] selftests: net: disable rp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512160421.GO3339421@horms.kernel.org>
Date: Mon, 12 May 2025 17:04:21 +0100
From: Simon Horman <horms@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Matthieu Baerts <matttbe@...nel.org>,
	Mat Martineau <martineau@...nel.org>,
	Geliang Tang <geliang@...nel.org>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	Andrea Mayer <andrea.mayer@...roma2.it>,
	Paolo Lungaroni <paolo.lungaroni@...roma2.it>,
	linux-kselftest@...r.kernel.org, mptcp@...ts.linux.dev,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org
Subject: Re: [PATCHv2 net-next 1/6] selftests: net: disable rp_filter after
 namespace initialization

On Thu, May 08, 2025 at 08:19:05AM +0000, Hangbin Liu wrote:
> Some distributions enable rp_filter globally by default. To ensure consistent
> behavior across environments, we explicitly disable it in several test cases.
> 
> This patch moves the rp_filter disabling logic to immediately after the
> network namespace is initialized. With this change, individual test cases
> with creating namespace via setup_ns no longer need to disable rp_filter
> again.
> 
> This helps avoid redundancy and ensures test consistency.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>