netdev - Re: [PATCH net-next] net: stmmac: convert to ndo_hwtstamp_get() and ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76961134-0676-4ec5-b5e1-5a9693bff268@linux.dev>
Date: Mon, 12 May 2025 17:31:57 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, Russell King <linux@...linux.org.uk>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Richard Cochran <richardcochran@...il.com>,
 Furong Xu <0x1207@...il.com>
Subject: Re: [PATCH net-next] net: stmmac: convert to ndo_hwtstamp_get() and
 ndo_hwtstamp_set()

On 12/05/2025 16:58, Vladimir Oltean wrote:
> On Mon, May 12, 2025 at 04:50:35PM +0100, Vadim Fedorenko wrote:
>> On 12/05/2025 15:36, Vladimir Oltean wrote:
>>> New timestamping API was introduced in commit 66f7223039c0 ("net: add
>>> NDOs for configuring hardware timestamping") from kernel v6.6. It is
>>> time to convert the stmmac driver to the new API, so that the
>>> ndo_eth_ioctl() path can be removed completely.
>>
>> The conversion to the new API looks good, but stmmac_ioctl() isn't
>> removed keeping ndo_eth_ioctl() path in place. Did I miss something in
>> the patch?
> 
> I was never intending with this work to remove ndo_eth_ioctl()
> completely, but instead to completely remove the timestamping
> configuration path that goes through ndo_eth_ioctl(). I apologize for
> any false marketing and I will be more explicit about this in further
> patches.

Got it. The patch itself looks good:
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>