netdev - Re: [PATCH net v2] qlcnic: fix memory leak in qlcnic_sriov_channel_cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512165701.GT3339421@horms.kernel.org>
Date: Mon, 12 May 2025 17:57:01 +0100
From: Simon Horman <horms@...nel.org>
To: Abdun Nihaal <abdun.nihaal@...il.com>
Cc: shshaikh@...vell.com, manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, sucheta.chakraborty@...gic.com,
	rajesh.borundia@...gic.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] qlcnic: fix memory leak in
 qlcnic_sriov_channel_cfg_cmd()

On Mon, May 12, 2025 at 10:18:27AM +0530, Abdun Nihaal wrote:
> In one of the error paths in qlcnic_sriov_channel_cfg_cmd(), the memory
> allocated in qlcnic_sriov_alloc_bc_mbx_args() for mailbox arguments is
> not freed. Fix that by jumping to the error path that frees them, by
> calling qlcnic_free_mbx_args(). This was found using static analysis.
> 
> Fixes: f197a7aa6288 ("qlcnic: VF-PF communication channel implementation")
> Signed-off-by: Abdun Nihaal <abdun.nihaal@...il.com>
> ---
> This patch is only compile tested. Not tested on real hardware.
> 
> V1->V2 : Added information about how the bug was found and how the 
> patch was tested, as suggested by Simon Horman.
> 
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Thanks for the update.

Reviewed-by: Simon Horman <horms@...nel.org>