netdev - Re: [PATCH net-next v2] openvswitch: Stricter validation for the userspace action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512171807.GU3339421@horms.kernel.org>
Date: Mon, 12 May 2025 18:18:07 +0100
From: Simon Horman <horms@...nel.org>
To: Eelco Chaudron <echaudro@...hat.com>
Cc: netdev@...r.kernel.org, dev@...nvswitch.org, aconole@...hat.com,
	i.maximets@....org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next v2] openvswitch: Stricter validation for the
 userspace action

On Mon, May 12, 2025 at 10:08:24AM +0200, Eelco Chaudron wrote:
> This change enhances the robustness of validate_userspace() by ensuring
> that all Netlink attributes are fully contained within the parent
> attribute. The previous use of nla_parse_nested_deprecated() could
> silently skip trailing or malformed attributes, as it stops parsing at
> the first invalid entry.
> 
> By switching to nla_parse_deprecated_strict(), we make sure only fully
> validated attributes are copied for later use.
> 
> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
> ---
> v2: Changed commit message based on Ilya's feedback.

Reviewed-by: Simon Horman <horms@...nel.org>