netdev - Re: [PATCH net-next v2] net: Add support for providing the PTP hardware source in tsinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250512165749.375bcbbd@kernel.org>
Date: Mon, 12 May 2025 16:57:49 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Donald Hunter <donald.hunter@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Jason Xing <kernelxing@...cent.com>, Richard Cochran
 <richardcochran@...il.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, "Russell King (Oracle)"
 <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v2] net: Add support for providing the PTP
 hardware source in tsinfo

On Mon, 12 May 2025 10:19:42 +0200 Kory Maincent wrote:
> > -    name: ts-hwtstamp-source
> > -    enum-name: hwtstamp-source
> > -    header: linux/ethtool.h
> > +    name: hwtstamp-source
> > +    name-prefix: hwtstamp-source-
> >      type: enum
> > -    name-prefix: hwtstamp-source  
> 
> Should we keep the enum-name property as is is already use, or do you prefer to
> rename all its use to ethtool-hwtstamp-source?

Looks like we already have a number of such cases - attribute name 
and enum name are the same. I'd keep them the same, I don't think
there's much room for confusion either in C or Python.