netdev - Re: [PATCH net-next 1/4] net: bonding: add broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCAD8257-E275-4251-8E6D-815D583907BF@bamaicloud.com>
Date: Mon, 12 May 2025 16:55:36 +0800
From: Tonghao Zhang <tonghao@...aicloud.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org,
 Jay Vosburgh <jv@...sburgh.net>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>,
 Andrew Lunn <andrew+netdev@...n.ch>
Subject: Re: [PATCH net-next 1/4] net: bonding: add broadcast_neighbor option
 for 802.3ad

> 2025年5月12日 下午4:22，Hangbin Liu <liuhangbin@...il.com> 写道：
> 
> On Sat, May 10, 2025 at 12:45:01PM +0800, tonghao@...aicloud.com wrote:
>> diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
>> index 1e13bb170515..76f2a1bf57c2 100644
>> --- a/drivers/net/bonding/bond_sysfs.c
>> +++ b/drivers/net/bonding/bond_sysfs.c
>> @@ -752,6 +752,23 @@ static ssize_t bonding_show_ad_user_port_key(struct device *d,
>> static DEVICE_ATTR(ad_user_port_key, 0644,
>> 		   bonding_show_ad_user_port_key, bonding_sysfs_store_option);
>> 
>> +static ssize_t bonding_show_broadcast_neighbor(struct device *d,
>> +					       struct device_attribute *attr,
>> +					       char *buf)
>> +{
>> +	struct bonding *bond = to_bond(d);
>> +	const struct bond_opt_value *val;
>> +
>> +	val = bond_opt_get_val(BOND_OPT_BROADCAST_NEIGH,
>> +			bond->params.broadcast_neighbor);
> 
> nit: please take care of the code alignment here
OK
>> +
>> +	return sysfs_emit(buf, "%s %d\n", val->string,
>> +			bond->params.broadcast_neighbor);
> 
>                       here
Ok, thanks Hangbin.
>> +}
>> +
>> +static DEVICE_ATTR(broadcast_neighbor, 0644,
>> +		   bonding_show_broadcast_neighbor, bonding_sysfs_store_option);
> 
> and here.
OK
> 
> Thanks
> Hangbin
>