netdev - Re: [PATCH net-next v10 02/13] net: pse-pd: Add support for reporting events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250513114409.6aae3eb9@kmaincent-XPS-13-7390>
Date: Tue, 13 May 2025 11:44:09 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, Donald Hunter <donald.hunter@...il.com>, Rob Herring
 <robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman
 <horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
 Chevallier <maxime.chevallier@...tlin.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v10 02/13] net: pse-pd: Add support for
 reporting events

On Thu, 8 May 2025 20:10:41 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Tue, 06 May 2025 11:38:34 +0200 Kory Maincent wrote:
> > diff --git a/Documentation/netlink/specs/ethtool.yaml
> > b/Documentation/netlink/specs/ethtool.yaml index c650cd3dcb80..fbfd293987c1
> > 100644 --- a/Documentation/netlink/specs/ethtool.yaml
> > +++ b/Documentation/netlink/specs/ethtool.yaml
> > @@ -98,6 +98,12 @@ definitions:
> >      name: tcp-data-split
> >      type: enum
> >      entries: [ unknown, disabled, enabled ]
> > +  -
> > +    name: pse-events
> > +    type: flags
> > +    name-prefix: ethtool-pse-event-
> > +    header: linux/ethtool.h
> > +    entries: [ over-current, over-temp ]  
> 
> please change this enum similarly to what I suggested on the hwts
> source patch

Ok.

> >  attribute-sets:
> >    -
> > @@ -1528,6 +1534,18 @@ attribute-sets:
> >          name: hwtstamp-flags
> >          type: nest
> >          nested-attributes: bitset
> > +  -
> > +    name: pse-ntf
> > +    attr-cnt-name: __ethtool-a-pse-ntf-cnt  
> 
> please use -- instead of underscores

All the other attributes are using underscore in this property.
Are you sure about this?

> > +			phydev = psec->attached_phydev;
> > +			if (phydev->attached_dev) {
> > +				netdev = phydev->attached_dev;
> > +				netdev_hold(netdev, tracker, GFP_ATOMIC);  
> 
> GFP_KERNEL ?

Oops indeed, small copy paste mistake.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com