netdev - Re: [net v2] octeontx2-pf: macsec: Fix incorrect max transmit size in TX secy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250513131905.GZ3339421@horms.kernel.org>
Date: Tue, 13 May 2025 14:19:05 +0100
From: Simon Horman <horms@...nel.org>
To: Subbaraya Sundeep <sbhatta@...vell.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, gakula@...vell.com,
	hkelam@...vell.com, sgoutham@...vell.com, lcherian@...vell.com,
	bbhushan2@...vell.com, jerinj@...vell.com, sd@...asysnail.net,
	netdev@...r.kernel.org
Subject: Re: [net v2] octeontx2-pf: macsec: Fix incorrect max transmit size
 in TX secy

On Mon, May 12, 2025 at 06:12:36PM +0530, Subbaraya Sundeep wrote:
> MASCEC hardware block has a field called maximum transmit size for
> TX secy. Max packet size going out of MCS block has be programmed
> taking into account full packet size which has L2 header,SecTag
> and ICV. MACSEC offload driver is configuring max transmit size as
> macsec interface MTU which is incorrect. Say with 1500 MTU of real
> device, macsec interface created on top of real device will have MTU of
> 1468(1500 - (SecTag + ICV)). This is causing packets from macsec
> interface of size greater than or equal to 1468 are not getting
> transmitted out because driver programmed max transmit size as 1468
> instead of 1514(1500 + ETH_HDR_LEN).
> 
> Fixes: c54ffc73601c ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading")
> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>

Thanks, I see that OTX2_ETH_HLEN is already taken into account in several
places including otx2_hw_set_mtu() and otx2_get_max_mtu(). So I agree with
this change.

Reviewed-by: Simon Horman <horms@...nel.org>

...