netdev - Re: [PATCH] ixgbe/ipsec: use memzero_explicit() for stack SA structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250513133152.4071482-1-zilin@seu.edu.cn>
Date: Tue, 13 May 2025 13:31:52 +0000
From: Zilin Guan <zilin@....edu.cn>
To: dawid.osuchowski@...ux.intel.com
Cc: andrew+netdev@...n.ch,
	anthony.l.nguyen@...el.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	intel-wired-lan@...ts.osuosl.org,
	jianhao.xu@....edu.cn,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	przemyslaw.kitszel@...el.com,
	zilin@....edu.cn
Subject: Re: [PATCH] ixgbe/ipsec: use memzero_explicit() for stack SA structs

On Tue, May 13, 2025 at 12:24:41PM+0000, Zilin Guan wrote:
> Both paths return immediately on key-parsing failure, should I add a 
> memzero_explicit(&rsa, sizeof(rsa)) before Rx-SA's return or remove the 
> memset(&tsa, ...) in the Tx-SA path to keep them consistent?
> 
> Best Regards,
> Zilin Guan

If this change is required, should I submit it as a new standalone patch, 
or include it in a v2 of the existing patch series?