lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250513155957.700c1a05@kmaincent-XPS-13-7390> Date: Tue, 13 May 2025 16:00:15 +0200 From: Kory Maincent <kory.maincent@...tlin.com> To: Maxime Chevallier <maxime.chevallier@...tlin.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, thomas.petazzoni@...tlin.com, Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org, Christophe Leroy <christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>, Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>, Marek Behún <kabel@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>, Nicolò Veronese <nicveronese@...il.com>, Simon Horman <horms@...nel.org>, mwojtas@...omium.org, Antoine Tenart <atenart@...nel.org>, devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, Romain Gantois <romain.gantois@...tlin.com>, Daniel Golle <daniel@...rotopia.org>, Dimitri Fedrau <dimitri.fedrau@...bherr.com> Subject: Re: [PATCH net-next v6 04/14] net: phy: dp83822: Add support for phy_port representation On Wed, 7 May 2025 15:53:20 +0200 Maxime Chevallier <maxime.chevallier@...tlin.com> wrote: > With the phy_port representation intrduced, we can use .attach_port to > populate the port information based on either the straps or the > ti,fiber-mode property. This allows simplifying the probe function and > allow users to override the strapping configuration. > > Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com> > --- ... > +static int dp83822_attach_port(struct phy_device *phydev, struct phy_port > *port) +{ > + struct dp83822_private *dp83822 = phydev->priv; > + int ret; > + > + if (port->mediums) { > + if (phy_port_is_fiber(port)) > + dp83822->fx_enabled = true; > + } else { > + ret = dp83822_read_straps(phydev); > + if (ret) > + return ret; > + > +#ifdef CONFIG_OF_MDIO if IS_ENABLED(CONFIG_OF_MDIO) seems to be more used than ifdef Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Powered by blists - more mailing lists